Bug 74543

Summary:

Support a second software-button area for the trackstick

Product:

xorg

Reporter:

Peter Hutterer <peter.hutterer>

Component:

Input/synaptics

Assignee:

Benjamin Tissoires <benjamin.tissoires>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

medium

CC:

benjamin.tissoires, peter.hutterer

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

74544

Attachments:

Description	Flags
0001-Add-secondary-top-software-buttons-area.patch	none
policy for RHEL 6 T440s	none
0001-Add-secondary-top-software-buttons-area.patch	none

Description Peter Hutterer 2014-02-05 00:46:47 UTC

For the Lenovo T440 laptops and similar models. Add a second software button area at the top of the touchpad that can provide LMR buttons for the trackstick.

IMO this area doesn't need to be exposed through properties, we're likely detecting the devices that need it based on udev tags and MatchTag configuration items. So static configuration is fine.

Proposed size of the area maybe 10-20% of the touchpad, testing will show the best value for that.

Comment 1 Benjamin Tissoires 2014-02-10 17:06:07 UTC

Created attachment 93789 [details] [review]
0001-Add-secondary-top-software-buttons-area.patch

Add proposed patch to fix the enhancement.

As mentioned in the bug, no configuration is possible besides the static one.

Comment 2 Peter Hutterer 2014-02-10 21:52:10 UTC

Comment on attachment 93789 [details] [review]
0001-Add-secondary-top-software-buttons-area.patch

Review of attachment 93789 [details] [review]:
-----------------------------------------------------------------

typo: "same semantics as .."

should we force the top edge to 0?
other than that, looks good.

Comment 3 Benjamin Tissoires 2014-02-14 00:45:44 UTC

Created attachment 94034 [details]
policy for RHEL 6 T440s

Adding a policy file for the settings I used in the T440s, if that matters (can be easily converted to a xorg.conf.d file).

Comment 4 Benjamin Tissoires 2014-02-20 18:21:41 UTC

Created attachment 94452 [details] [review]
0001-Add-secondary-top-software-buttons-area.patch

Updated patch taking into account:

- fixed typo
- renamed TopSoftButtonAreas into SecondarySoftButtonAreas. The rational is to keep the code simple (i.e. reuse the old one), but preventing the incoherence regarding the top parameter not forced to 0.

Comment 5 Peter Hutterer 2014-02-21 01:27:22 UTC

amended a bunch of things in the man page, but otherwise left as-is.

commit 402cc872570b58b8420e7973d0706f3b2a2aaf91
Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Thu Feb 20 13:13:18 2014 -0500

    Add secondary (top) software buttons area

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.