| Summary: | piglit CorrectVersion1.V110 regression regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | Matt Turner <mattst88> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | cworth, huax.lu, idr, jljusten, mattst88, mesa-dev |
| Version: | git | Keywords: | regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| URL: | http://patchwork.freedesktop.org/patch/19014/ | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Patch on the list. Thanks for the report! *** Bug 74207 has been marked as a duplicate of this bug. *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
$ ./bin/glslparsertest tests/glslparsertest/shaders/CorrectVersion1.V110.frag fail 1.10 Successfully compiled fragment shader tests/glslparsertest/shaders/CorrectVersion1.V110.frag: Shader source: // [config] // expect_result: fail // glsl_version: 1.10 // // # NOTE: Config section was auto-generated from file // # NOTE: 'glslparser.tests' at git revision // # NOTE: 6cc17ae70b70d150aa1751f8e28db7b2a9bd50f0 // [end config] /* Only one version statement is allowed; two should raise an error. */ #version 110 #version 110 void main() { gl_FragColor = vec4(1); } PIGLIT: {'result': 'fail' } 3e0e9e3bf9e597eb74b06381b3418c958be4d452 is the first bad commit commit 3e0e9e3bf9e597eb74b06381b3418c958be4d452 Author: Matt Turner <mattst88@gmail.com> Date: Sat Jan 25 11:57:02 2014 -0800 glcpp: Check version_resolved in the proper place. The check was in the wrong place, such that if a shader incorrectly put a preprocessor token before the #version declaration, the version would be resolved twice, leading to a segmentation fault when attempting to redefine the __VERSION__ macro. #extension GL_ARB_sample_shading: require #version 130 void main() {} Also, rename glcpp_parser_resolve_version to glcpp_parser_resolve_implicit_version to avoid confusion. Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Carl Worth <cworth@cworth.org> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> :040000 040000 76acfdd0bf7846e51a3fa988fdd58f74a57f8dce 1265d3bc1b129beae3f07a28ab4e2f0b1261feda M src bisect run success