Bug 73114

Patch submitted to https://gerrit.libreoffice.org/7225

can you show an after picture... and especially an after picture _when_ one is logged in.. since that is the interesting case...

I do not mind picking the patch.. but since I do not see that problem
here, even not logged in.. it is hard to tell.

actually playing with it.. it seems that the overlap occurs regardless of the log in status.. it is just a question of how wide is the display space...
so a better solution maybe would be to make the 'logo' section be 'transparent'
or otherwise in the 'background'  (note I do not know what is possible with css, and the term I used to describe things are not necessarily the relevant concept in css)
or any other solution that would 'scale'
the propose patch seems to just to hide the problem for a specific size of window...

Created attachment 91853 [details]
screenshot with possible related problem

Attached screenshot shows missing scrollbar in code pane, as well as overlapping logo.
Changing the width of the webbrowser window makes the scrollbars appear.
If related, it would be nice to check against the patch as well.

First, sorry for very late reply.

If we want to get the logo at the same point (topmost, in the middle), I still can't figure out how to do it properly. However, what I've found are:

1. We can make it "looks" transparent, by changing "background-color: #ffffff" to "background-color: transparent" in GerritSite.css.

BUT, this only hides the problem, because the logo is still on top, not really in the back, ie. you can't click in the search box in overlapping area.


2. We can add and run javascript in the header, by adding the code snippets into GerritSiteHeader.html. I thought that the code should check the width of class "topmenuTDglue", which has the only element between left-sided menu and right-sided search box, and then adjust the logo size as following its width.

The example code, add this to GerritSiteHeader.html:
> <script type="text/javascript">
>   e = document.getElementsByClassName("topmenuTDglue").item(0).getBoundingClientRect();
>   // More info at https://developer.mozilla.org/en-US/docs/Web/API/element.getBoundingClientRect
> </script>

BUT, all the pages are loaded in javascript manner, including "topmenuTDglue", (to prove this: view the real source of page, not from developer console). So our script might run *before* the page loaded successfully -> the script couldn't find the element and return null.

----

Or, we should move it to another place, as Bjoern suggested in https://gerrit.libreoffice.org/7225


Also, I'm sorry to say that I don't have time to fix this bug anymore. So, I put this back to NEW and un-assigned myself.

@Winfried, Yes, I also encountered that problem, but (1) I don't think that's the same problem with this bug, and (2) I didn't check if it's resolved or not. :\