| Summary: | Confusing internal API for BusTransation | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Chengwei Yang <chengwei.yang.cn> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | chengwei.yang.cn |
| Version: | 1.5 | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review? | ||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH] BusTransaction: returns its own connections through getter
[PATCH] BusTransaction: remove confusing getter of connections |
||
|
Description
Chengwei Yang
2013-11-14 08:42:29 UTC
Created attachment 89181 [details] [review] [PATCH] BusTransaction: returns its own connections through getter Can the two lists ever be different? For instance, it might be the case that one of them contains "completed" connections, and the other also includes connections that have not yet authenticated. (In reply to comment #2) > Can the two lists ever be different? For instance, it might be the case that > one of them contains "completed" connections, and the other also includes > connections that have not yet authenticated. (In reply to comment #2) > Can the two lists ever be different? For instance, it might be the case that > one of them contains "completed" connections, and the other also includes > connections that have not yet authenticated. This patch doesn't introduce any behaviour change, just make the code (internal API) a little less confusing. In fact, yes they are different, one is a pointer of DBusList while the other one is a pointer of BusConnections. :-) Since we can use a more clear API bus_context_get_connections() to get context->connections, I think it's better to make bus_transaction_get_connections() to return its own connections, a pointer to DBusList. (In reply to comment #3) > (In reply to comment #2) > > Can the two lists ever be different? For instance, it might be the case that > > one of them contains "completed" connections, and the other also includes > > connections that have not yet authenticated. > > This patch doesn't introduce any behaviour change, just make the code > (internal API) a little less confusing. > > In fact, yes they are different, one is a pointer of DBusList while the > other one is a pointer of BusConnections. :-) BusConnection contains two DBusList<DBusConnection> lists, "completed" and "incomplete". BusTransaction.connections could reasonably correspond to completed, or the union of completed and incomplete, or something else entirely (just the connections involved in the transaction, maybe). From a skim-read, it looks like it's actually the connections involved in the transaction. > Since we can use a more clear API bus_context_get_connections() to get > context->connections, I think it's better to make > bus_transaction_get_connections() to return its own connections, a pointer > to DBusList. If bus_transaction_get_connections() currently returns the complete set of connections, and none of its callers actually need access to BusTransaction.connections, then I'd prefer to delete bus_transaction_get_connections() entirely (replacing it with the equivalent calls to bus_context_get_connections), rather than changing its semantics to something nobody needs. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Can the two lists ever be different? For instance, it might be the case that > > > one of them contains "completed" connections, and the other also includes > > > connections that have not yet authenticated. > > > > This patch doesn't introduce any behaviour change, just make the code > > (internal API) a little less confusing. > > > > In fact, yes they are different, one is a pointer of DBusList while the > > other one is a pointer of BusConnections. :-) > > BusConnection contains two DBusList<DBusConnection> lists, "completed" and > "incomplete". BusTransaction.connections could reasonably correspond to > completed, or the union of completed and incomplete, or something else > entirely (just the connections involved in the transaction, maybe). From a > skim-read, it looks like it's actually the connections involved in the > transaction. > > > Since we can use a more clear API bus_context_get_connections() to get > > context->connections, I think it's better to make > > bus_transaction_get_connections() to return its own connections, a pointer > > to DBusList. > > If bus_transaction_get_connections() currently returns the complete set of > connections, and none of its callers actually need access to > BusTransaction.connections, then I'd prefer to delete Yes, as you can see, no one needs BusTransaction.connections. > bus_transaction_get_connections() entirely (replacing it with the equivalent > calls to bus_context_get_connections), rather than changing its semantics to > something nobody needs. Hmm, I have no objection to do this, both of them are fine to me, a unused getter for BusTransaction.connections or delete it. Anyway, I'll upload a v2 which delete it totally. Created attachment 89929 [details] [review] [PATCH] BusTransaction: remove confusing getter of connections deleted unused bus_transaction_get_connections() Fixed in git for 1.7.10 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.