| Summary: | [Gen4-5 clip] Piglit spec_OpenGL_1.1_polygon-offset hits (execsize >= width) assertion | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | fangxun <xunx.fang> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | medium | CC: | huax.lu, idr |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
fangxun
2013-10-14 05:53:13 UTC
It also happens on mesa 10.0 branch(commit:44e38a878aef79b53dd1) Please confirm that this is seen on SNB or newer platform. (In reply to comment #2) > Please confirm that this is seen on SNB or newer platform. It works well on SNB+ platforms. It also works well on ILK with mesa master branch. Only fails on ILK with mesa 10.2 branch. output: polygon-offset: brw_eu_emit.c:267: validate_reg: Assertion `execsize >= width' failed. Aborted (core dumped) This bug report seems to be full of mistakes. I can reproduce this assertion failure on ILK with today's Mesa master. I happened to have a Mesa build of commit c402aed handy, which was master from March 2013 - 7 months prior to the bisected commit - and prior to the 9.2.0 release. I hit the exact same assertion failure. It looks like this is currently broken, and all of the related code appears to git blame to the original 2006 driver import from Tungsten, so I suspect it's been broken since the dawn of time. This should also be broken on Broadwater, Crestline, Eaglelake, and Cantiga...not just Ironlake. On the plus side, I believe I've fixed it: http://lists.freedesktop.org/archives/mesa-dev/2014-August/064899.html Note that this test would have passed in release builds, but hit the assertion fail in debug builds. Accidentally using a release build instead of a debug build could explain some of the instances where it appeared to be fixed/broken. Fixed by: commit b7679639bcc8ac72cb08c48f9cda8eecd6a9c1e5 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Tue Aug 5 23:57:17 2014 -0700 i965/clip: Fix brw_clip_unfilled.c/compute_offset's assembly. Due to the destination register width of 1 or 2, these instructions get ExecSize 1 or 2. But dir and offset (used as src0) are both registers of width 4, violating the execsize >= width assertion. I honestly don't think this could have ever worked. Fixes Piglit's polygon-offset and polygon-mode-offset tests on Gen4-5. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70441 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Chris Forbes <chrisf@ijw.co.nz> It works well on master branch, but still fails on 10.2 branch. (In reply to comment #7) > It works well on master branch, but still fails on 10.2 branch. The commit is part of the 10.2.7 release. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.