Bug 68493

mesa: 288a25252386d2cc372a5938fd4ff05879efd3ca (master)

piglit layout-column_major-non-uniform regressed on softpipe and llvmpipe.


$ ./bin/glslparsertest tests/spec/arb_uniform_buffer_object/compiler/layout-column_major-non-uniform.frag fail 1.20
Successfully compiled fragment shader tests/spec/arb_uniform_buffer_object/compiler/layout-column_major-non-uniform.frag: 0:21(28): warning: uniform block layout qualifiers row_major and column_major applied to non-matrix types may be rejected by older compilers

Shader source:
// [config]
// expect_result: fail
// glsl_version: 1.20
// require_extensions: GL_ARB_uniform_buffer_object
// [end config]

/* From the GL_ARB_uniform_buffer_object_spec:
 *
 *     "Uniform block layout qualifiers can be declared at global
 *      scope, on a single uniform block, or on a single block member.
 *
 *      At global scope, it is an error to use layout qualifiers to
 *      declare a variable. Instead, at global scope, layout
 *      qualifiers apply just to the keyword uniform and establish
 *      default qualification for subsequent blocks:"
 */

#version 120
#extension GL_ARB_uniform_buffer_object: require

layout(column_major) vec4 a;

vec4 foo(void) {
	return a;
}

PIGLIT: {'result': 'fail' }


dded321f92e4727584a98b71d7aaa15d4f01fb24 is the first bad commit
commit dded321f92e4727584a98b71d7aaa15d4f01fb24
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Thu Aug 15 11:24:11 2013 -0700

    glsl: Give a warning, not an error, for UBO qualifiers on non-matrices.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59648
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>

:040000 040000 2e6215681d169859bfba5df48f0d6bf7f8d761d3 e4792099b2f2a89ae3d09e802b97c62086ce573a M	src
bisect run success