Bug 68283

Summary: Bonjour requires ports to be specified in network-byte-order
Product: PulseAudio Reporter: Kenneth Perry <thothonegan>
Component: modulesAssignee: pulseaudio-bugs
Status: RESOLVED FIXED QA Contact: pulseaudio-bugs
Severity: normal    
Priority: medium CC: lennart
Version: unspecifiedKeywords: patch
Hardware: x86-64 (AMD64)   
OS: Mac OS X (All)   
i915 platform: i915 features:
Attachments: Patch that uses htons to return ports in network byteorder

Description Kenneth Perry 2013-08-19 15:54:45 UTC
Created attachment 84255 [details] [review]
Patch that uses htons to return ports in network byteorder

For DNS-SD (Bonjour) discovery, all ports should be set in network byteorder instead of host byteorder. Without this, all ports on little-endian systems (intel) are incorrect. Patch attached that uses htons() to return the port in network order.

Documentation: https://developer.apple.com/library/mac/documentation/networking/Reference/DNSServiceDiscovery_CRef/Reference/reference.html#//apple_ref/c/func/DNSServiceRegister
Comment 1 Tanu Kaskinen 2013-12-05 09:24:06 UTC
Thanks! We have a long patch queue, so getting around to this took long, but now the patch has been applied.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.