Bug 67279

Summary:	[PATCH] test/marshal: Ensure we use suitably aligned buffers
Product:	dbus	Reporter:	Colin Walters <walters>
Component:	core	Assignee:	Colin Walters <walters>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	hp, smcv, walters
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	r+
i915 platform:		i915 features:
Attachments:	0001-test-marshal-Ensure-we-use-suitably-aligned-buffers.patch

Description Colin Walters 2013-07-24 21:52:36 UTC

This test was failing on s390; though it could fail
on other platforms too.  Basically we need to be sure
we're passing at least word-aligned buffers to the
demarshalling code.  malloc() will do that for us.
---
 test/marshal.c | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)

Comment 1 Colin Walters 2013-07-24 21:53:22 UTC

Created attachment 82965 [details] [review]
0001-test-marshal-Ensure-we-use-suitably-aligned-buffers.patch

Comment 2 Simon McVittie 2013-07-25 10:02:25 UTC

Comment on attachment 82965 [details] [review]
0001-test-marshal-Ensure-we-use-suitably-aligned-buffers.patch

Review of attachment 82965 [details] [review]:
-----------------------------------------------------------------

Sure. Please merge to dbus-1.6 too, if applicable.

Comment 3 Colin Walters 2013-07-25 13:16:56 UTC

Pushed to master and cherry-picked to 1.6.  Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.