Bug 64520

Summary:	add Contact_Info_Field_Flag_Read_Only, for GTalk <URL>
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-spec	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	CC:	will, xclaesse
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review?
i915 platform:		i915 features:
Attachments:	Contact_Info_Field_Flag_Read_Only: add

Description Simon McVittie 2013-05-13 08:23:00 UTC

+++ This bug was initially created as a clone of Bug #64319 +++

Google recently added Google Plus URLs to GTalk users' XMPP vCards. Based on some experimenting with the telepathy-gabble XMPP console, these turn out to be read-only: you can try to set the <URL> to a different value, and it will claim to succeed, but it has no effect.

With current Gabble, the field just doesn't appear in the Empathy UI (and Empathy crashes, but 3.8.2 will fix that, and I'm backporting that patch to 3.4.x for Debian).

With a Gabble in which Bug #64319 has been fixed, the field will appear in the Empathy UI and be editable. That doesn't seem great either: users will try to edit it and be surprised when they can't. What we want is that it appears, but is insensitive. To tell Empathy to do that, we'll need a Read_Only flag.

Any other XMPP dialects where the vCard is restricted, or where we fake up vCard fields (do we do that on Facebook?), should get the same treatment.

Comment 1 Simon McVittie 2014-01-07 14:39:48 UTC

Created attachment 91603 [details] [review]
Contact_Info_Field_Flag_Read_Only: add

---

Well, that was easy.

Remaining to do (untested pseudo-patch for Gabble):

       if (conn->features & GABBLE_CONNECTION_FEATURES_GOOGLE_ROSTER)
         {
           if (!tp_strdiff (vcard_name, "fn"))
             tp_flags |= TP_CONTACT_INFO_FIELD_FLAG_OVERWRITTEN_BY_NICKNAME;
+          else if (!tp_strdiff (vcard_name, "url"))
+            tp_flags |= TP_CONTACT_INFO_FIELD_FLAG_READ_ONLY;
         }

Comment 2 GitLab Migration User 2019-12-03 20:26:20 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-spec/issues/138.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.