Bug 63682

Summary:	[cmake] doesn't substitute @default_message_unix_fds@ in session.conf
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Havoc Pennington <hp>
Severity:	normal
Priority:	medium	CC:	ralf.habacker
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	cmake: define default_message_unix_fds so it can be substituted in session.conf Rename default_message_unix_fds to DEFAULT_MESSAGE_UNIX_FDS

Description Simon McVittie 2013-04-18 11:19:25 UTC

On Bug #54972, Ralf wrote:
> BTW: dbus-daemon rejected to start first because of the lack of
> dbus_message_unix_fds limit value in generated session.conf (see additional
> patch)

This is a regression since 1.7.0.

Comment 1 Simon McVittie 2013-04-18 11:43:08 UTC

Created attachment 78175 [details] [review]
cmake: define default_message_unix_fds so it can be  substituted in session.conf

This fixes a regression since 1.7.0: session.conf would be invalid when
generated by cmake.

Comment 2 Simon McVittie 2013-04-18 11:43:26 UTC

Created attachment 78176 [details] [review]
Rename default_message_unix_fds to  DEFAULT_MESSAGE_UNIX_FDS

As Ralf pointed out, we usually use upper-case when substituting
variables (apart from "somethingdir", which Autoconf conventionally
makes lower-case for some reason).

Comment 3 Ralf Habacker 2013-04-18 12:41:57 UTC

both patches are looking good. 
dbus-daemon compiled and run on windows msvc with cmake without any problem.

Comment 4 Simon McVittie 2013-04-22 15:27:33 UTC

Fixed in git for 1.7.2, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.