Bug 62987

Summary: module-coreaudio-detect should be default on MacOSX - or merged into modules-detect
Product: PulseAudio Reporter: Albert Zeyer <albzey>
Component: miscAssignee: pulseaudio-bugs
Status: RESOLVED FIXED QA Contact: pulseaudio-bugs
Severity: normal    
Priority: medium CC: adman.com, davec.bugs, lennart, springermac
Version: unspecifiedKeywords: love
Hardware: Other   
OS: Mac OS X (All)   
i915 platform: i915 features:
Attachments: patch for configure.ac
patch for configure
patch for default.pa
patch for system.pa
fix missing file

Description Albert Zeyer 2013-04-01 10:54:10 UTC
The default config on MacOSX doesn't work out-of-the-box. The main issue is that it uses modules-detect which doesn't find CoreAudio devices. It works mostly fine if it uses modules-coreaudio-detect.

I think it makes most sense to merge everything from modules-coreaudio-detect into modules-detect. Or that modules-detect, on MacOSX, automatically also loads modules-coreaudio-detect. Or so.
Comment 1 Tanu Kaskinen 2013-04-09 07:44:46 UTC
Yes, module-coreaudio-detect should be loaded by default.

I won't fix this myself, so patches welcome. I'll add the "love" keyword so that this bug shows up in the list of "easy" bugs.
Comment 2 Jonathan Springer 2014-11-27 03:27:18 UTC
Created attachment 110104 [details] [review]
patch for configure.ac
Comment 3 Jonathan Springer 2014-11-27 03:29:00 UTC
Created attachment 110105 [details] [review]
patch for configure

Checks for HAVE_COREAUDIO and if set adds it to confdefs.h
Comment 4 Jonathan Springer 2014-11-27 03:30:08 UTC
Created attachment 110106 [details] [review]
patch for default.pa

Uses modules-coreaudio-detect if HAVE_COREAUDIO is set
Comment 5 Jonathan Springer 2014-11-27 03:31:02 UTC
Created attachment 110107 [details] [review]
patch for system.pa

Uses modules-coreaudio-detect if HAVE_COREAUDIO is set
Comment 6 Jonathan Springer 2014-11-27 03:32:14 UTC
Added patches to use modules-coreaudio-detect in default.pa and system.pa if CoreAudio is detected during configure
Comment 7 Jonathan Springer 2014-11-27 03:34:36 UTC
Patches pulled from here https://gist.github.com/stephank/1633642 and applied to pulseaudio 5.0
Comment 8 Jonathan Springer 2015-01-24 01:06:43 UTC
Created attachment 112756 [details] [review]

Merge patches into one and fix messing with the generated configure by using configure.ac instead.
Comment 9 René J.V. Bertin 2015-02-01 15:41:43 UTC
The 1st hunk is missing the file to which it's supposed to apply!
Comment 10 Jonathan Springer 2015-02-01 16:23:17 UTC
Created attachment 113022 [details] [review]
fix missing file
Comment 11 René J.V. Bertin 2015-02-01 17:18:09 UTC
Comment on attachment 113022 [details] [review]
fix missing file

Review of attachment 113022 [details] [review]:

This isn't enough yet for me: I find that I still have to disable the loading of module-console-kit and module-systemd-login:

--- src/orig.default.pa  2015-01-23 02:45:48.000000000 +0100
+++ src/default.pa  2015-01-23 14:23:05.000000000 +0100
@@ -113,12 +117,12 @@
 ### If autoexit on idle is enabled we want to make sure we only quit
 ### when no local session needs us anymore.
-.ifexists module-console-kit.so
-load-module module-console-kit
-.ifexists module-systemd-login.so
-load-module module-systemd-login
+#.ifexists module-console-kit.so
+#load-module module-console-kit
+#.ifexists module-systemd-login.so
+#load-module module-systemd-login
 ### Enable positioned event sounds
 load-module module-position-event-sounds
Comment 12 Alexander E. Patrakov 2016-05-01 14:24:04 UTC
*** Bug 55154 has been marked as a duplicate of this bug. ***
Comment 13 Tanu Kaskinen 2016-05-01 15:30:43 UTC
This is fixed in 8.0 (at least the issue with module-coreaudio-detect not being loaded by default - if there are other issues, please file a new bug).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.