Bug 62840

Summary:	Stop using tp_handle_set_qdata() & tp_handle_get_qdata
Product:	Telepathy	Reporter:	Brian Pepple <bpepple>
Component:	rakia	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	mikhail.zabaluev
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Stop using handle qdata

Description Brian Pepple 2013-03-28 00:21:52 UTC

tp_handle_set_qdata() & tp_handle_get_qdata have been both deprecated in tp-glib-0.19.9.

handles.c: In function 'rakia_handle_inspect_uri':
handles.c:62:3: error: 'tp_handle_get_qdata' is deprecated (declared at /usr/include/telepathy-1.0/telepathy-glib/handle-repo.h:140) [-Werror=deprecated-declarations]
handles.c:68:7: error: 'tp_handle_set_qdata' is deprecated (declared at /usr/include/telepathy-1.0/telepathy-glib/handle-repo.h:137) [-Werror=deprecated-declarations]
cc1: all warnings being treated as errors

Comment 1 Brian Pepple 2013-03-28 00:23:08 UTC

Refer to: fdo #50886 & #54762

Comment 2 Simon McVittie 2013-06-03 15:11:01 UTC

Created attachment 80234 [details] [review]
Stop using handle qdata

The handles now live as long as the connection, so there's no point
in trying to bind to their lifetime; just keep a hash table.

Comment 3 Mikhail Zabaluev 2013-06-04 20:14:54 UTC

Comment on attachment 80234 [details] [review]
Stop using handle qdata

Review of attachment 80234 [details] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4 Simon McVittie 2013-08-07 16:17:30 UTC

Fixed in git for 0.7.5, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.