Bug 62839

Summary:	[Patch] Remove deprecated macros
Product:	Telepathy	Reporter:	Brian Pepple <bpepple>
Component:	rakia	Assignee:	Mikhail Zabaluev <mikhail.zabaluev>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to correct some deprecated macros.

Description Brian Pepple 2013-03-28 00:06:01 UTC

Created attachment 77133 [details] [review]
Patch to correct some deprecated macros.

I've attached a simple patch to fix some deprecated macros in tp-rakia that currently produce the following warnings:

configure.ac:30: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and will soon be removed.
configure.ac:30: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:30: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
docs/Makefile.am:70: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

Comment 1 Simon McVittie 2013-03-28 11:12:10 UTC

Comment on attachment 77133 [details] [review]
Patch to correct some deprecated macros.

Review of attachment 77133 [details] [review]:
-----------------------------------------------------------------

Looks good to me, except:

::: configure.ac
@@ +27,4 @@
>  dnl check for tools
>  AC_PROG_CC
>  AC_PROG_CC_STDC
> +AC_PROG_MKDIR_P

This was new in Autoconf 2.60, so it should come with a bump to AC_PREREQ([2.60]) (which I think is fine, 2.60 is more than 6 years old).

Comment 2 Simon McVittie 2013-03-28 11:19:21 UTC

Fixed in git for 0.7.5, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.