Bug 59835

Summary:	ir_constant_expression.cpp:156: undefined reference to `_mesa_round_to_even'
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	medium	CC:	chadversary
Version:	git	Keywords:	regression
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2013-01-25 05:58:23 UTC

mesa: 0974031f88c31458792864b2f3a46ff885607ab1 (master)

$ scons
[...]
  Linking build/linux-x86_64-debug/glsl/builtin_compiler/builtin_compiler ...
build/linux-x86_64-debug/glsl/ir_constant_expression.o: In function `pack_snorm_1x16':
mesa.bisect/src/glsl/ir_constant_expression.cpp:156: undefined reference to `_mesa_round_to_even'
build/linux-x86_64-debug/glsl/ir_constant_expression.o: In function `pack_unorm_1x16':
mesa.bisect/src/glsl/ir_constant_expression.cpp:192: undefined reference to `_mesa_round_to_even'
build/linux-x86_64-debug/glsl/ir_constant_expression.o: In function `pack_half_1x16':
mesa.bisect/src/glsl/ir_constant_expression.cpp:219: undefined reference to `_mesa_float_to_half'
build/linux-x86_64-debug/glsl/ir_constant_expression.o: In function `unpack_half_1x16':
mesa.bisect/src/glsl/ir_constant_expression.cpp:228: undefined reference to `_mesa_half_to_float'

eac030e38e3cdd4ed4534516e3d3a50c8a372719 is the first bad commit
commit eac030e38e3cdd4ed4534516e3d3a50c8a372719
Author: Chad Versace <chad.versace@linux.intel.com>
Date:   Wed Jan 16 19:49:40 2013 -0800

    mesa,glsl: Move round_to_even() from glsl to mesa/main (v2)
    
    Move round_to_even's definition to mesa/main so that _mesa_float_to_half()
    can use it in order to eliminate rounding bias.
    
    In additon to moving the fuction definition, prefix its name with "_mesa",
    just as all other functions in mesa/main are prefixed.
    
    v2: Fix Android build.
    
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
    Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

:040000 040000 60f8318121190570b92106da62352dd407e0b19e 61e7bc463c6b611cf6613968c99c8593115a5642 M	src
bisect run success

Comment 1 Vinson Lee 2013-01-25 06:46:15 UTC

Fixed by this commit.

commit 07e215f4ec80619b0eac26b8a5ec08572527c62a
Author: Vinson Lee <vlee@freedesktop.org>
Date:   Thu Jan 24 22:36:27 2013 -0800

    scons: Add imports.c to builtin_compiler build.
    
    Fixes build regression introduced by commit
    eac030e38e3cdd4ed4534516e3d3a50c8a372719.
    
    Signed-off-by: Vinson Lee <vlee@freedesktop.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59835

Comment 2 Chad Versace 2013-01-25 20:26:27 UTC

Sorry about that. Next time I change the Android and Autotools system, I'll remember to change Scons too.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.