Bug 59734

Summary: cmake 2.8.8 fixes
Product: dbus Reporter: Ralf Habacker <ralf.habacker>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED MOVED QA Contact:
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard: review-
i915 platform: i915 features:
Attachments: cmake 2.8.8 support

Description Ralf Habacker 2013-01-22 21:51:50 UTC
Created attachment 73481 [details] [review]
cmake 2.8.8 support
Comment 1 Simon McVittie 2013-01-23 11:23:30 UTC
Comment on attachment 73481 [details] [review]
cmake 2.8.8 support

Review of attachment 73481 [details] [review]:
-----------------------------------------------------------------

::: cmake/CMakeLists.txt
@@ +4,4 @@
>  CMAKE_MINIMUM_REQUIRED(VERSION 2.4.4 FATAL_ERROR)
>  if(COMMAND cmake_policy)
>      cmake_policy(SET CMP0003 NEW)
> +    cmake_policy(SET CMP0002 OLD)

What does the OLD CMP0002 policy mean?

(Yes, I know I can go and look it up in the cmake documentation, but I shouldn't have to, because the commit message should tell me.)

Instead of selecting the OLD behaviour, should we be changing other stuff so that the NEW behaviour is valid?
Comment 2 Simon McVittie 2013-01-23 11:24:35 UTC
"""
For example, CMake 2.6 introduces policy CMP0002 which requires all logical target names to be globally unique (duplicate target names previously worked in some cases by accident but were not diagnosed). Projects using duplicate target names and working accidentally will receive warnings referencing the policy.
"""

Can't we fix the duplicate target names instead? What are they?
Comment 3 Ralf Habacker 2013-01-23 12:27:09 UTC
(In reply to comment #2)
> """
> For example, CMake 2.6 introduces policy CMP0002 which requires all logical
> target names to be globally unique (duplicate target names previously worked
> in some cases by accident but were not diagnosed). Projects using duplicate
> target names and working accidentally will receive warnings referencing the
> policy.
> """
> 
> Can't we fix the duplicate target names instead? 

I can evaulate this. 

> What are they?

These are doc related.
Comment 4 Simon McVittie 2013-02-12 10:56:12 UTC
It occurs to me that your commit 1e1e4c92a might have fixed this?

Please remove "review-" from the status whiteboard when there's something here to review again.
Comment 5 Ralf Habacker 2013-02-12 12:17:36 UTC
(In reply to comment #4)
> It occurs to me that your commit 1e1e4c92a might have fixed this?
> 
yes
> Please remove "review-" from the status whiteboard when there's something
> here to review again.

fixed in bug 59733

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.