Bug 59094

mesa: afec10df373f342f058aab66c622237964a4a147 (master)

Run piglit GL_EXT_texture_snorm get-renderbuffer-internalformat on softpipe or llvmpipe.

$ ./bin/get-renderbuffer-internalformat GL_EXT_texture_snorm -auto
Using test set: GL_EXT_texture_snorm
Testing GL_RED_SNORM: OK
Testing GL_R8_SNORM: OK
Testing GL_RG_SNORM: OK
Testing GL_RG8_SNORM: OK
Testing GL_RGB_SNORM: OK
Testing GL_RGB8_SNORM: OK
Testing GL_RGBA_SNORM: OK
Testing GL_RGBA8_SNORM: OK
Testing GL_ALPHA_SNORM: OK
Testing GL_ALPHA8_SNORM: OK
Mesa: User error: GL_INVALID_ENUM in glRenderbufferStorage(internalFormat)
Testing GL_LUMINANCE_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE_SNORM)
Testing GL_LUMINANCE8_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE8_SNORM)
Testing GL_LUMINANCE_ALPHA_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE_ALPHA_SNORM)
Testing GL_LUMINANCE8_ALPHA8_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE8_ALPHA8_SNORM)
Testing GL_INTENSITY_SNORM: FAIL (GL_RGBA instead of GL_INTENSITY_SNORM)
Testing GL_INTENSITY8_SNORM: FAIL (GL_RGBA instead of GL_INTENSITY8_SNORM)
Testing GL_R16_SNORM: OK
Testing GL_RG16_SNORM: OK
Testing GL_RGB16_SNORM: OK
Testing GL_RGBA16_SNORM: OK
Testing GL_ALPHA16_SNORM: OK
Testing GL_LUMINANCE16_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE16_SNORM)
Testing GL_LUMINANCE16_ALPHA16_SNORM: FAIL (GL_RGBA instead of GL_LUMINANCE16_ALPHA16_SNORM)
Testing GL_INTENSITY16_SNORM: FAIL (GL_RGBA instead of GL_INTENSITY16_SNORM)
PIGLIT: {'result': 'fail' }

4b92379da213c85998643997deef945b6e7fb7a7 is the first bad commit
commit 4b92379da213c85998643997deef945b6e7fb7a7
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Sat Dec 1 11:06:48 2012 -0800

    mesa: Disallow deprecated SNORM formats for renderbuffers
    
    The OpenGL 3.2 core profile spec says:
    
        "The following base internal formats from table 3.11 are
        color-renderable: RED, RG, RGB, and RGBA. The sized internal formats
        from table 3.12 that have a color-renderable base internal format
        are also color-renderable. No other formats, including compressed
        internal formats, are color-renderable."
    
    The OpenGL 3.2 compatibility profile spec says (only ALPHA is added):
    
        "The following base internal formats from table 3.16 are
        color-renderable: ALPHA, RED, RG, RGB, and RGBA. The sized internal formats
        from table 3.17 that have a color-renderable base internal format
        are also color-renderable. No other formats, including compressed
        internal formats, are color-renderable."
    
    Table 3.12 in the core profile spec and table 3.17 in the compatibility
    profile spec list SNORM formats as having a base internal format of RED,
    RG, RGB, or RGBA.  From this we infer that they should also be color
    renderable.
    
    The OpenGL ES 3.0 spec says:
    
        "An internal format is color-renderable if it is one of the formats
        from table 3.12 noted as color-renderable or if it is unsized format
        RGBA or RGB. No other formats, including compressed internal
        formats, are color-renderable."
    
    In the OpenGL ES 3.0 spec, none of the SNORM formats have "color-
    renderable" marked in table 3.12.  The RGB I and UI formats also are not
    color-renderable in ES3, but we'll save that change for another patch.
    
    Both NVIDIA's closed-source driver (version 304.64) and AMD's
    closed-source driver (Catalyst 12.6 on HD 3650) reject *all* SNORM
    formats for renderbuffers in OpenGL 3.3 compatibility profiles.
    
    v2: Move {RED,RG,RGB,RGBA}_SNORM changes from the this commit to the
    next commit.  Based on suggestions from Ken.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Marek Olšák <maraeo@gmail.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Eric Anholt <eric@anholt.net>

:040000 040000 3e4fc5d041d08c8e3ed586b4b93718061637fe34 8526a533f2bba2dc94a1af475cdc69d5e1c9e64d M	src
bisect run success