Bug 56925

Summary:	add support for --with-valgrind=auto
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	hp
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	non-maintainer r+
i915 platform:		i915 features:
Attachments:	Add support for configuring --with-valgrind=auto

Description Simon McVittie 2012-11-09 14:45:17 UTC

Created attachment 69817 [details] [review]
Add support for configuring --with-valgrind=auto

This is the configuration I'd like to use for the "debug build" of dbus on Debian - if we use --with-valgrind=yes, we have to hard-code knowledge of which architectures do and don't have Valgrind in two places instead of just one.

Comment 1 Simon McVittie 2012-11-09 14:47:08 UTC

(In reply to comment #0)
> two places instead of just one

... namely, the list of build-dependencies in debian/control (which will continue to list supported architectures), and the call to configure in debian/rules (which will no longer need to).

Comment 2 Chengwei Yang 2013-09-29 09:04:40 UTC

Comment on attachment 69817 [details] [review]
Add support for configuring --with-valgrind=auto

Review of attachment 69817 [details] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3 Simon McVittie 2013-09-30 11:36:15 UTC

None of the maintainers vetoed this, so I'll apply it next time I do a test build.

Comment 4 Simon McVittie 2013-10-08 09:54:55 UTC

fixed in git for 1.7.6

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.