Bug 56852

Summary:	gypsy should not use -Werror
Product:	Gypsy	Reporter:	Allison Lortie (desrt) <desrt>
Component:	General	Assignee:	iain <iain>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Use the GNOME_COMPILE_WARNINGS([maximum]) macro instead of -Werror

Description Allison Lortie (desrt) 2012-11-07 20:33:00 UTC

gypsy's build is broken right now due to use of -Werror and the fact that g_type_init() has been deprecated.

there are really three bugs here, but I'll avoid the spam because they're all somewhat related:


1) don't enable -Werror by default

2) (possibly) stop calling g_type_init()

3) for the future, set GLIB_VERSION_MAX_ALLOWED and GLIB_VERSION_MIN_REQUIRED to the glib version you target in order to avoid deprecation warnings that you don't care about

Comment 1 Evan Nemerson 2013-01-02 23:47:57 UTC

Created attachment 72403 [details] [review]
Use the GNOME_COMPILE_WARNINGS([maximum]) macro instead of -Werror

(In reply to comment #0)
> gypsy's build is broken right now due to use of -Werror and the fact that
> g_type_init() has been deprecated.
> 
> there are really three bugs here, but I'll avoid the spam because they're
> all somewhat related:
> 
> 
> 1) don't enable -Werror by default

I doubt gypsy wants to depend on gnome-common, but how about copying http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-compiler-flags.m4 into the gypsy tree?  It does not cause an error for deprecated-deprecations, but it does catch some additional problems...  For example, it causes an error on missing-prototypes, which caught the bugs described in bug #58961.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.