Bug 50378

Summary:	xdg-open no longer respects DE variable
Product:	Portland	Reporter:	Zhehao Mao <zhehao.mao>
Component:	xdg-utils	Assignee:	Portland Bugs <portland-bugs>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	1.1.0 rc1
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Suggested changes to xdg-open

Description Zhehao Mao 2012-05-26 14:06:16 UTC

Created attachment 62128 [details] [review]
Suggested changes to xdg-open

I am a former xfce user who now uses openbox, but I still prefer to use exo-open as a backend to xdg-open. Before I set the DE environmental variable to xfce to make xdg-open use exo-open, but now a detectDE function has been added to the script which overrides the DE variable set by the user. Could you modify the script so that it does not run detectDE if DE is already set? I've attached a diff showing what I mean.

Comment 1 Rex Dieter 2012-05-26 18:55:54 UTC

The fact that setting DE= ever worked was an unfortunate happenstance, you should not rely on that.

xdg-utils *does* however now respect setting XDG_CURRENT_DESKTOP

Comment 2 Rex Dieter 2012-08-09 12:46:30 UTC

After thinking it over, my gut reaction still tells me relying on an undocumented environment variable named "DE" is just not safe.

Let's stick with XDG_CURRENT_DESKTOP

Comment 3 Rex Dieter 2012-08-09 13:43:10 UTC

I take it back the current code in git should actually respect current values for  DE= as  it turns out.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.