Bug 49471

Summary: Add a WockyConnector::connection-established
Product: Wocky Reporter: Jonny Lamb <jonny.lamb>
Component: GeneralAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://cgit.freedesktop.org/~jonny/wocky/log/?h=connection-established
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 49473    

Description Jonny Lamb 2012-05-04 03:29:44 UTC
I want a way to get to the socket as early as possible to set TCP_NODELAY. This is one way of doing it.

Another way would be have a wocky_connector_set_tcp_nodelay(WockyConnector *, gboolean) like Twisted does. I'm not really fussed.

wocky-connector-test is basically the only test which actually touches sockets (the rest use fake streams which just pass strings around which is good) so I set TCP_NODELAY there too which dropped the running time of all the tests from 37s to 10s. Not bad.
Comment 1 Jonny Lamb 2012-05-04 03:30:14 UTC
You could argue that TCP_NODELAY should only be enabled for non-releases. Thoughts?
Comment 2 Jonny Lamb 2012-08-31 11:13:25 UTC
I added ifdefs for G_OS_UNIX.
Comment 3 Jonny Lamb 2012-09-17 14:10:19 UTC
Merged after review on IRC from Simon, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.