Summary: | The keyboard "model" abnt2 is not compatible with the US Layout | ||
---|---|---|---|
Product: | xkeyboard-config | Reporter: | Victor Bogado da Silva Lins <victor> |
Component: | doc | Assignee: | xkb |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | high | Keywords: | movetoxkc |
Version: | unspecified | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Diff for the file /usr/lib/X11/xkb/keycodes/xfree86
Diff for the file /usr/lib/X11/xkb/symbols/br patch to symbols/br patch to keycodes/xfree86 new patch to keycodes/xfree86 |
Description
Victor Bogado da Silva Lins
2005-10-27 16:41:25 UTC
Created attachment 3646 [details] [review] Diff for the file /usr/lib/X11/xkb/keycodes/xfree86 Submited the diff for /usr/lib/X11/xkb/keycodes/xfree86 Created attachment 3647 [details] [review] Diff for the file /usr/lib/X11/xkb/symbols/br diff file uploaded committed to xkeyboard-config. could you please check it works ok. Dealing with the development of some new variants for the brazilian (br) layout, I found out that the proposed fix keeps the abnt2 model incompatible with other models that map the 94 scancode the the LSGT keycode. Wouldn't it be better for the abnt2 model to follow the pattern of other models? If you want to, for instance, use model abnt2 and layout pt (portuguese), or model pc104 or pc105 and layout br, the LSGT keycode will work either way. ------ keycodes/xfree86 diff ------ 414c414 < <AC13> = 94; --- > <LSGT> = 94; ------ symbols/br diff ------ 38c38 < key <AC13> { [ backslash, bar, masculine, dead_breve ] }; --- > key <LSGT> { [ backslash, bar, masculine, dead_breve ] }; Created attachment 7845 [details] [review] patch to symbols/br Created attachment 7846 [details] [review] patch to keycodes/xfree86 Yes, these patch look reasonable. Committed. (In reply to comment #7) > Yes, these patch look reasonable. Committed. > The second patch is correct? <LSGT> = 94; is from xfree86(basic) and will be inherited by abnt2. Only remove the <AC13> = 94; is a good idea (i think). Piter,
LSGT seems not be in xfree86(basic), but in xfree86(xfree86), which also
defines <BKSL> = 51;
I changed it now, and it is working fine:
------ diff to keycodes/xfree86
412,414c412
< include "xfree86(basic)"
< <BKSL> = 51;
< <LSGT> = 94;
---
> include "xfree86(xfree86)"
------
The BKSL and LSGT keys are still recognized, and this way I think the abnt2
model stays the most compatible with other models.
Created attachment 7860 [details] [review] new patch to keycodes/xfree86 I already noticed that optimization, see in CVS:) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.