Bug 4578

Summary:

Make Xming use shared libraries

Product:

xorg

Reporter:

Colin Harrison <colin.harrison>

Component:

Server/DDX/Xwin

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

Version:

unspecified

Hardware:

x86 (IA32)

OS:

Windows (All)

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

1690

Attachments:

Description	Flags
Rules patch	none
Server Imakefile pthread library change	none
The essential bit was missed out	none

Description Colin Harrison 2005-09-24 05:02:32 UTC

Following a recent tree change that make libXau and libXdmcp shared by default,
Xming failed to build the libXdmcp.dll.
The Xming build is currently build with static libs, the attached patch makes 
the build shared and fixes the above problem.
DLL's built:-
libXau-6.dll, libX11-6.dll, libXext-6.dll, libXdmcp-6.dll.
Only libX11-6.dll libXdmcp-6.dll are really needed, from the xc tree, to run 
Xming.exe/xkbcomp.exe.
The patch also simplifies the mingw.rules file a little and is maybe a useful 
first step to going modular.

Comment 1 Colin Harrison 2005-09-24 05:06:03 UTC

Created attachment 3392 [details] [review]
Rules patch

Comment 2 Colin Harrison 2005-11-08 02:14:02 UTC

Created attachment 3733 [details] [review]
Server Imakefile pthread library change

Change to use pthread GC2 for shared library build of Xming.

Comment 3 Colin Harrison 2005-11-14 08:35:03 UTC

This bug should not block any release as it only affects the crosscompile of 
the Xming server using Mingw.
http://freedesktop.org/wiki/Xming
With no current Xming maintainer is there any other sponser who can verify the 
release of these patches?

Comment 4 Adam Jackson 2005-11-19 05:12:25 UTC

looks good to me.  applied, thanks!

Comment 5 Colin Harrison 2005-11-20 02:12:38 UTC

Following the CVS commit

in xc/config/cf/mingw.rules
 
#define HasSharedLibraries     YES

is essential, without the YES (missing in latest CVS mingw.rules) the 
crosscompile build bombs out.

Comment 6 Colin Harrison 2005-11-23 20:07:48 UTC

Created attachment 3879 [details] [review]
The essential bit was missed out

The essential part of the mingw.rules patch got missed out for some reason.

Comment 7 Colin Harrison 2005-11-23 20:10:19 UTC

The essential part of the change got missed out and as a result the Xming build 
bombs out.

Comment 8 Adam Jackson 2005-11-30 16:55:43 UTC

this time for sure!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.