Bug 45773

Summary:	yts-plugins make distcheck fails on buildbot
Product:	Ytstenut	Reporter:	Alvaro Soliverez <alvaro.soliverez>
Component:	plugins	Assignee:	Robert Staudinger <robert.staudinger>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	jonny.lamb, olli.salli
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	0001-build-Fix-make-distcheck.patch

Description Alvaro Soliverez 2012-02-08 05:45:54 UTC

In buildbot, running make distcheck fails with the following error:

make[2]: Entering directory `/var/lib/buildbot/telepathy/yts-plugins-default-i386/build/tests/twisted'
make[2]: *** No rule to make target `accounts/README', needed by `distdir'.  Stop.
make[2]: Leaving directory `/var/lib/buildbot/telepathy/yts-plugins-default-i386/build/tests/twisted'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/var/lib/buildbot/telepathy/yts-plugins-default-i386/build/tests'
make: *** [distdir] Error 1
program finished with exit code 2

See the whole build log here: http://buildbot.telepathy.im:8010/builders/ytstenut-plugins%20-%20i386/builds/36

Comment 1 Robert Staudinger 2012-02-08 07:06:05 UTC

Probably a case of taking the README from wherever repo tests/twisted/Makefile.am was originally inspired from.

Jonny you're the only one left of the names git-blame spits out, any idea? Gabble possibly?

Comment 2 Robert Staudinger 2012-02-08 12:02:01 UTC

Created attachment 56764 [details] [review]
0001-build-Fix-make-distcheck.patch

Comment 3 Robert Staudinger 2012-02-08 12:02:41 UTC

Proposed patch.

Comment 4 Olli Salli 2012-02-08 12:16:38 UTC

++. Good catch on the deprecated INIT_AUTOMAKE usage.

Comment 5 Robert Staudinger 2012-02-08 12:56:45 UTC

commit 80d6dd530bbda5e58e9620c45caca51ea6490ba9
Author: Rob Staudinger <robsta@linux.intel.com>
Date:   Wed Feb 8 20:55:44 2012 +0100

    build: Fix 'make distcheck'
    
    A few filenames in tests/twisted/tools were too long for default 'tar',
    call AM_INIT_AUTOMAKE with 'tar-ustar' for remedy.
    
    Also tests/twisted/Makefile.am had non-existant files in EXTRA_DIST,
    which prevented the dist from finishing. Remove those.
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45773

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.