Bug 45602

Summary: use TpBaseChannel more
Product: Telepathy Reporter: Jonny Lamb <jonny.lamb>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://cgit.freedesktop.org/~jonny/telepathy-gabble/log/?h=base-channels
Whiteboard: review+
i915 platform: i915 features:

Description Jonny Lamb 2012-02-03 16:49:54 UTC 
(deliberately no patch keyword for now, but feel free to review so far)

Gabble should use TpBaseChannel more. Here are some patches to make do exactly that. I've still got GabbleTubeStream to split up too but I thought I'd just post my progress for the time being here.

After this I'll be removing Tubes channels. I just wish they weren't so tangled into everything in Gabble and Salut. :-(
Comment 1 Jonny Lamb 2012-02-28 15:55:27 UTC 
Okay, I finished this. What do you think?

  86 files changed, 902 insertions(+), 1973 deletions(-)
Comment 2 Jonny Lamb 2012-02-28 15:56:13 UTC 
(In reply to comment #1)
>   86 files changed, 902 insertions(+), 1973 deletions(-)

Oh this is wrong, ignore it please.
Comment 3 Simon McVittie 2012-02-29 03:52:39 UTC 
FT ++
Comment 4 Simon McVittie 2012-02-29 04:04:26 UTC 
All ++.

Other things you could do if you felt like it:

- make TpBaseChannel officially a prerequisite of the Tube GInterface

- try extracting a superclass for the two Tube channels

Those might be too much to bother with right now, though.
Comment 5 Jonny Lamb 2012-02-29 12:34:12 UTC 
(In reply to comment #4)
> Those might be too much to bother with right now, though.

lol no thanks.

Merged!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.