| Summary: | The server-file-transfer example is not very exemplary | ||
|---|---|---|---|
| Product: | Ytstenut | Reporter: | Robert Staudinger <robert.staudinger> |
| Component: | tp-ytstenut | Assignee: | Robert Staudinger <robert.staudinger> |
| Status: | NEW --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | olli.salli |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | https://github.com/r0b5t4/telepathy-ytstenut/commit/8e330375ce4d874e522d5a94947e91a22d84531c | ||
| Whiteboard: | review- | ||
| i915 platform: | i915 features: | ||
|
Description
Robert Staudinger
2012-02-02 14:47:37 UTC
Patch, good to go? The patch does multiple unrelated things in the same commit: * make cosmetic changes to variable naming * start using GOptions * using it, make some formerly hardcoded variables specified on the command line * invent new format for addressing the recipient service when sending * finally, add the TpYtsClient when receiving (what this bug was specifically about) I'm not saying these changes are bad; on the contrary, they are sensible and superficially seem well executed. However, it's hard to review them all in one (especially because some things are just cosmetics and non-functional refactoring), and also the patch description becomes misleading. Thus, please split to smaller commits resembling something like the above outline. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.