Summary: | Add a configure time switch to enable/disable the plugins required | ||
---|---|---|---|
Product: | Ytstenut | Reporter: | Siraj Razick <siraj> |
Component: | plugins | Assignee: | Siraj Razick <siraj> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | medium | CC: | olli.salli |
Version: | unspecified | Keywords: | patch |
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.collabora.com/git/user/siraj/ytstenut-plugins.git/commit/?h=compile-fix&id=60269d18c1738bf52cb462ed47d7648acec39702 | ||
Whiteboard: | review+ after a small change | ||
i915 platform: | i915 features: |
Description
Siraj Razick
2011-12-30 12:54:06 UTC
patch adds the options to choose the plugins we need to build. +LT_INIT([disable-static win32-dll]) +m4_ifdef([LT_OUTPUT], [LT_OUTPUT]) What's this? Should this be in a separate commit? I don't see anything about win32 in the commit message? +AC_ARG_ENABLE(telepathy-salut-plugin, I reckon we could get rid of the "telepathy-" prefix; the option is really long! This goes for the gabble one too. Otherwise seems fine. oops yeah.. those two lines have leaked from another WIP patch. anyways..new patch -> Siraj, you really should have one branch per fd.o bug, and all the patches in the branch belong to that bug. This is because review is done at the bug level; when a bug gets review+ you can then just merge the whole branch. And again, keyword, not whiteboard for "patch", please. + AS_HELP_STRING([--enable-salut-plugin],[build telepathy-salut plugin default=yes]), + enable_salut_plugin=$enableval,enable_salut_plugin=no) Doesn't look like the default would be yes, although the help string says so? I think both gabble and salut plugin should default to yes for consistency. So consider this accepted after flipping the default for salut. This seems to have been merged. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.