Bug 44256

Summary:	The build does not produce .dll files when cross compiled for windows
Product:	Ytstenut	Reporter:	Siraj Razick <siraj>
Component:	plugins	Assignee:	Siraj Razick <siraj>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	olli.salli
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/siraj/ytstenut-plugins.git/commit/?h=api-update&id=ce18d501355ce9477d5d9c3ff12db6f3d8287bb8
Whiteboard:	review+
i915 platform:		i915 features:
Bug Depends on:	44331, 44649, 46245
Bug Blocks:

Description Siraj Razick 2011-12-28 21:04:29 UTC

in the current source plugins Makefile.am defines AM_LDFLAGS = -module -avoid-version -shared , resulting in static libraries when we cross compile for windows.
to trick libtool to produce .dll files, we need to change this to  -no-undefined for windows. 

the problem with this is, we need to LIBADD all the dependant libraries at compile time, and specially with gabble, we need to add telepathy-gabble/src/libgabble-convenience.la which is internal to gabble.

Comment 1 Olli Salli 2012-01-12 01:42:20 UTC

Siraj, please cook up a branch fixing this with the assumption that we'll someday have a gabble-plugins.dll with all the required symbols, whenever you're blocked on actually implementing whatever solution we come up for that in bug 44649.

When done, please add the cgit shortlog of that as URL and add patch keyword as per Ytstenut review procedure.

Thanks!

Comment 2 Siraj Razick 2012-01-24 18:03:00 UTC

once all the patches are merged.. this patch will produce .dll files on windows

Comment 3 Jonny Lamb 2012-01-26 15:00:14 UTC

Seems reasonable.

Comment 4 Olli Salli 2012-02-07 05:48:28 UTC

This has been merged already.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.