| Summary: | Add versioninfo to executable | ||
|---|---|---|---|
| Product: | dbus | Reporter: | René Berber <Rene.Berber> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED DUPLICATE | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | enhancement | ||
| Priority: | medium | CC: | msniko14, ralf.habacker |
| Version: | 1.5 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Adds versioninfo & manifest to dbus-daemon on Windows build. | ||
|
Description
René Berber
2011-12-23 17:31:41 UTC
Bug still present in version 1.8.4, and it has a related problem: missing manifest (i.e. related because the manifest can/should be included inside the .rc file -- and both linked into the executable). The lack of a manifest means dbus-daemon is running in an "Operating System Context" of Windows Vista, while the real OS is Windows 7, 8, or 8.1. What's the real performance impact? I don't really know, I'm no Windows expert. But read this if you want to get an idea: http://msdn.microsoft.com/en-us/library/windows/desktop/hh848036%28v=vs.85%29.aspx Created attachment 107642 [details] [review] Adds versioninfo & manifest to dbus-daemon on Windows build. Just like the description says. Notes: Its mostly a copy of what exists in the library, doesn't change that part at all (versioninfo is not added to the library, and unless it is somehow linked to the executable, its useless in the library). Added the executable manifest, a simple one, that defines compatibility with all versions of Windows from XP to 10. This avoids running the program in a Vista compatible way, which is the default for Win 7 and later. Didn't add anything to the other executables produced in the build. Comment on attachment 107642 [details] [review] Adds versioninfo & manifest to dbus-daemon on Windows build. Review of attachment 107642 [details] [review]: ----------------------------------------------------------------- This seems a lot like Bug #103387. Ralf, please could you check whether there's anything here that we'll still want after applying your patch from Bug #103387? ::: bus/Makefile.am @@ +6,5 @@ > +# > +#if DBUS_WIN > + > +%.o: %.rc > + $(WINDRES) $< -o $@ This needs to be $(RC) since 1.11.22 ::: bus/dbus.manifest @@ +1,4 @@ > +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> > +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" > + xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"> > +<description>DBus</description> Either "dbus-daemon" or "D-Bus message bus service" depending what conventionally appears here @@ +4,5 @@ > +<description>DBus</description> > +<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"> > + <security> > + <requestedPrivileges> > + <requestedExecutionLevel level="asInvoker" uiAccess="false"/> Ralf, is this something we should be adding to all executables? @@ +19,5 @@ > + <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/> > + <!-- The ID below indicates app support for Windows 8.1 --> > + <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/> > + <!-- The ID below indicates app support for Windows 10 --> > + <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/> I can see that this might be something we might want? ::: bus/versioninfo.rc.in @@ +11,5 @@ > + */ > + > +/* This file is processed by configure to create versioninfo.rc */ > + > +#line __LINE__ "versioninfo.rc.in" We had some trouble with #line directives in MSVC's resource compiler (Bug #103015) so we probably need to lose that part. @@ +36,5 @@ > + BLOCK "StringFileInfo" > + BEGIN > + BLOCK "040904b0" > + BEGIN > + VALUE "Comments", "Provided under the terms of the GNU Lesser General Public License.\0" This isn't true: dbus is dual-licensed under GPL-2.0 (or any later version) or AFL-2.1. It isn't LGPL. @@ +41,5 @@ > + VALUE "CompanyName", "FreeDesktop.org\0" > + VALUE "FileDescription", "dbus - FreeDesktop message bus system\0" > + VALUE "FileVersion", "@DBUS_VERSION@\0" > + VALUE "InternalName", "dbus\0" > + VALUE "LegalCopyright", "Copyright © 2009 - 2014 FreeDesktop.org\0" The form we used in the other .rc file was © 1994-2017 dbus contributors, see dbus source code for details since freedesktop.org is not a copyright holder. (The copyright holders are individual contributors, like Ralf Habacker for his contributions, or their employers, like Collabora Ltd. for my contributions.) *** This bug has been marked as a duplicate of bug 103387 *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.