| Summary: | Call: Mute interface doesn't have Media side | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Olivier Crête <olivier.crete> |
| Component: | tp-spec | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | Call, review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: |
Add Muted and Pending_Mute states
Patch that also removes the paused state |
||
|
Description
Olivier Crête
2011-12-15 16:24:09 UTC
Created attachment 54476 [details] [review] Add Muted and Pending_Mute states Created attachment 54477 [details] [review] Patch that also removes the paused state I have no idea what the paused state is for, so I just removed it.. My guess is that is was to implement Mute, but it's quite unclear to me. + The streaming implementation has successfully muted sending, + and the local user's privacy is protected. + The streaming implementation has been told to mute sending, + but it has not yet indicated that it has done so. Not sure why your indentation is funky here. Otherwise it looks fine. Merge away. (In reply to comment #3) > Not sure why your indentation is funky here. (As in, please fix this before merging.) commit 52dd16e0f2b4d5b6077debfb4238668610e0fe79 Author: Olivier Crête <olivier.crete@collabora.com> Date: Thu Dec 15 19:25:44 2011 -0500 Stream.I.Media: Add Muted and Pending_Mute stream flow states. This way the CM can tell the streaming implementation to mute. Also, remove the useless Paused state |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.