Bug 43588

Summary:	dataforms in caps for plugins
Product:	Telepathy	Reporter:	Alban Crequy <alban.crequy>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/alban/telepathy-gabble.git/commit/?h=caps
Whiteboard:	review+
i915 platform:		i915 features:

Description Alban Crequy 2011-12-07 10:42:51 UTC

gabble_connection_add_sidecar_own_caps() allows a Gabble plugin to get the XEP-0115 verification string by giving the features and identities but not dataforms.

The code in Gabble to parse and hash dataforms exist but it is not exposed in the signature of gabble_connection_add_sidecar_own_caps(). It should be made available for plugins.

The following patch fixes it.

Comment 1 Jonny Lamb 2011-12-13 02:09:16 UTC

Looks good. Merge away.

Comment 2 Alban Crequy 2011-12-13 04:18:51 UTC

Patch merged:


commit e61ea6b4baa4080e072f69699bc876c762797b5d
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date:   Wed Dec 7 13:19:22 2011 +0000

    Add gabble_connection_add_sidecar_own_caps_full() with dataforms
    
    https://bugs.freedesktop.org/show_bug.cgi?id=43588

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.