Bug 43421

Summary:	TpSimpleHandler doc uses deprecated symbol in example
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:

Description Xavier Claessens 2011-12-01 06:40:06 UTC

The example code uses tp_simple_handler_new() which is deprecated.

The reason it is deprecated is that constructor was calling tp_account_manager_dup() internally but some handlers does not want a full AM to be prepared, so tp_simple_handler_new_with_am() and tp_simple_handler_new_with_factory() where introduced.

So the example should be changed to use one of those. Similar change needs to be done for observer/approver.

Fix: http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=fix-example

Another solution that I personally prefer is undeprecate tp_simple_handler_new() but slightly change its behaviour and stop creating a TpAM internally but create a TpAutomaticClientFactory instead. It could also accept NULL TpDBusDaemon and use internally tp_dbus_daemon_dup(). Like that we simplify basic use cases where all the app wants is just handling channels.

Fix: http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=base-client


Make your choice of which branch to merge :)

Comment 1 Jonny Lamb 2011-12-13 02:15:53 UTC

I think I prefer option one here but I'm ready to be convinced we should undeprecate tp_simple_handler_new()?

Merge away to the first one though; sorry for the delay in reviewing.

Comment 2 Xavier Claessens 2011-12-13 05:17:02 UTC

Ok merged the solution #1 in stable and master. Since we are going to break API/ABI in "next" branch, we could reconsider this at that moment.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.