Bug 42981

Summary:	Fail to prepare TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS when connecting a Haze connection
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	guillaume.desmottes
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=proxy-31583
Whiteboard:
i915 platform:		i915 features:
Attachments:	Retry to prepare features which failed because of a missing conn iface

Description Guillaume Desmottes 2011-11-16 03:03:28 UTC

Original bug report: https://bugzilla.gnome.org/show_bug.cgi?id=663957

We try to prepare the feature while the account is connecting. At this Connection's interfaces does not contain Avatars yet, so the preparation of the feature fails:

tp-glib/proxy-DEBUG: check_feature_interfaces: Proxy doesn't implement org.freedesktop.Telepathy.Connection.Interface.Avatars, can't prepare feature tp-connection-feature-avatar-requirements


When the connection is connected, its interface property gains Avatars but that's too late, the feature has failed and won't be prepared again.

Comment 1 Guillaume Desmottes 2011-11-16 03:21:19 UTC

I guess the proper way to fix this is, once connected, to retry to prepare the features which have failed because of their requiered interfaces weren't there.

Comment 2 Guillaume Desmottes 2011-11-16 05:27:12 UTC

http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=proxy-31583

My branch is based on top of master for testing purposes but the fix should be in 0.14 as well.

Comment 3 Guillaume Desmottes 2012-04-27 01:21:05 UTC

Created attachment 60653 [details] [review]
Retry to prepare features which failed because of a missing conn iface

If we try to prepare a connection feature before the connection is connected,
the preparation may fall if a required interface hasn't been announced yet by
the CM. So, we give those features a second chance to be prepared when the
connection has been connected.

Comment 4 Xavier Claessens 2012-04-27 01:32:58 UTC

Looks good, +1

Comment 5 Guillaume Desmottes 2012-04-27 01:43:38 UTC

Merged to stable for 0.18.2.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.