Summary: | shell-test doesn't need --enable-embedded-tests and could be installed | ||
---|---|---|---|
Product: | dbus | Reporter: | Simon McVittie <smcv> |
Component: | core | Assignee: | Simon McVittie <smcv> |
Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
Severity: | enhancement | ||
Priority: | medium | CC: | hp |
Version: | 1.4.x | Keywords: | patch |
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.freedesktop.org/~smcv/dbus/log/?h=14-shell-test-42811 | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 36074 | ||
Attachments: |
[1/2] Allow a reduced set of installable tests (none yet) to be built without GLib
[2/2] Mark shell-test as modular and installable |
Description
Simon McVittie
2011-11-11 03:29:44 UTC
Created attachment 53395 [details] [review] [1/2] Allow a reduced set of installable tests (none yet) to be built without GLib --enable-modular-tests=auto will build as many as possible, perhaps excluding the GLib ones. --enable-modular-tests=yes or --enable-tests=yes will insist on having GLib, to be able to run everything. Created attachment 53396 [details] [review] [2/2] Mark shell-test as modular and installable This test needs non-public API and so is statically linked, but is OK to install. ssh://people.freedesktop.org/~smcv/dbus.git 14-shell-test-42811 Comment on attachment 53395 [details] [review] [1/2] Allow a reduced set of installable tests (none yet) to be built without GLib Review of attachment 53395 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 53396 [details] [review] [2/2] Mark shell-test as modular and installable Review of attachment 53396 [details] [review]: ----------------------------------------------------------------- I'm gonna trust your word on this. Thanks, merged for 1.5.10. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.