| Summary: | Subject interface needs to define more unknowns for properties | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Danielle Madeley <danielle> |
| Component: | tp-spec | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/danni/telepathy-spec.git/log/?h=subject-42652 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Chan.I.Subject: add values for when properties are unknown
Chan.I.Subject: remove a white lie Make unknown timestamp a G_MAXINT64 Return the appropriate value in the case of an unknown timestamp wocky-muc: return NULL if a timestamp can't be determined |
||
|
Description
Danielle Madeley
2011-11-06 21:04:17 UTC
Created attachment 53227 [details] [review] Chan.I.Subject: add values for when properties are unknown Specifically ActorHandle and Timestamp. Created attachment 53228 [details] [review] Chan.I.Subject: remove a white lie Skype does not permit subjects on 1:1 chats. However, XMPP does, e.g. GMail will include a 'subject' node when you click "Reply to Will by chat". Comment on attachment 53227 [details] [review] Chan.I.Subject: add values for when properties are unknown Review of attachment 53227 [details] [review]: ----------------------------------------------------------------- ::: spec/Channel_Interface_Subject.xml @@ +95,4 @@ > type="x" tp:type="Unix_Timestamp64" access="read"> > <tp:docstring xmlns="http://www.w3.org/1999/xhtml"> > <p>A unix timestamp indicating when the subject was last > + modified, or <code>INT_MAX64</code> if unknown.</p> Okay, provided Gabble and Idle are updated to respect this. (They both use 0, explicitly and implicitly, respectively.) Comment on attachment 53228 [details] [review] Chan.I.Subject: remove a white lie Review of attachment 53228 [details] [review]: ----------------------------------------------------------------- Looks good. Merged. Patches for gabble and idle to follow. Created attachment 53236 [details] [review] Make unknown timestamp a G_MAXINT64 This makes idle compliant with the updated spec. Comment on attachment 53236 [details] [review] Make unknown timestamp a G_MAXINT64 Review of attachment 53236 [details] [review]: ----------------------------------------------------------------- yarr. Created attachment 53238 [details] [review] Return the appropriate value in the case of an unknown timestamp This updates Gabble for the latest spec. Fixes: Created attachment 53239 [details] [review] wocky-muc: return NULL if a timestamp can't be determined Fixes: The Gabble and Wocky bugs look good, too. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.