Bug 42589

Summary: Call1: Content and Stream ifaces could optionally implement Mute
Product: Telepathy Reporter: Xavier Claessens <xclaesse>
Component: tp-specAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: olivier.crete
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/xclaesse/telepathy-spec.git/log/?h=call1-mute
i915 platform: i915 features:

Description Xavier Claessens 2011-11-04 06:01:02 UTC
Mute iface says:
It should always be possible to mute an entire call. It is sometimes also possible to mute individual Contents (e.g. to prevent background noise from disturbing other participants, but remain visible on webcam) or to mute individual streams (e.g. to "whisper" to other call participants)

I understand this as Type.Call1 MUST implement Mute, Call1.Content and Call1.Stream COULD implement Mute.

Atm Call1.Content's spec says it MUST implement Mute, and Call1.Stream does not mention Mute at all.

In spec, we can use <tp:requires interface=""/> to make the extra iface mandatory, but we have nothing to tell it is optional. So I suggest just removing the tp:requires from Call1.Content, and add in both Call1.Content and Call1.Stream a note in its description that it could implement Mute.
Comment 1 Xavier Claessens 2011-11-07 06:55:31 UTC
Here is a branch clarifying this.
Comment 2 Olivier CrĂȘte 2011-11-07 07:20:28 UTC
++ on the patch
Comment 3 Xavier Claessens 2011-11-07 07:30:50 UTC
thanks, merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.