Bug 41414

Summary:	tp_connection_upgrade_contacts() is not no-op if contacts are already prepared
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=no-op
Whiteboard:	review+ modulo adding g_test_bug()
i915 platform:		i915 features:

Description Xavier Claessens 2011-10-03 02:42:23 UTC

_contacts_by_handle() does strip out features that are already prepared on all contacts. The other paths should do as well.

Comment 1 Xavier Claessens 2011-10-03 04:39:34 UTC

Here is patch for tp_connection_upgrade_contacts().

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=no-op

Comment 2 Will Thompson 2011-10-03 16:01:15 UTC

+/* Regression test case for fd.o#41414 */
+static void
+test_upgrade_noop (Fixture *f,
+    gconstpointer unused G_GNUC_UNUSED)

Use

  g_test_bug ("41414");

Otherwise looks great.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.