Bug 41125

Summary: dbus_g_value_parse_variant leaks GVariant references
Product: dbus Reporter: Simon McVittie <smcv>
Component: GLibAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: normal    
Priority: medium CC: jonny.lamb, rob.taylor
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 41129    
Attachments: dbus_g_value_parse_variant: fix several GVariant ref leaks

Description Simon McVittie 2011-09-22 11:12:04 UTC 
Created attachment 51525 [details] [review]
dbus_g_value_parse_variant: fix several GVariant ref leaks

g_variant_get_child_value() (and hence g_variant_get_variant(), which is
a simple wrapper) returns a ref to the child; we were assuming it didn't.
Comment 1 Jonny Lamb 2012-03-09 10:18:31 UTC 
Comment on attachment 51525 [details] [review]
dbus_g_value_parse_variant: fix several GVariant ref leaks

Review of attachment 51525 [details] [review]:
-----------------------------------------------------------------

Looks good to me.
Comment 2 Simon McVittie 2012-03-09 10:49:12 UTC 
Thanks, fixed in git for 0.100.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.