Bug 41029

Summary: cmake issue: generating build timestamp
Product: dbus Reporter: Ralf Habacker <ralf.habacker>
Component: coreAssignee: Ralf Habacker <ralf.habacker>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: normal    
Priority: medium CC: hp, smcv
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
Whiteboard: review+ I suppose
i915 platform: i915 features:
Attachments: adds generating build timestamp to cmake

Description Ralf Habacker 2011-09-20 01:02:06 UTC
Created attachment 51390 [details]
adds generating build timestamp to cmake 

The appended patch fixes generating build timestamp for cmake in a platform independent manner.
Comment 1 Simon McVittie 2011-09-20 08:56:54 UTC
I'm not sure that a build timestamp is really particularly useful for a project that has branches, but if it's that important to you, yeah, apply it.
Comment 2 Ralf Habacker 2011-09-22 10:56:17 UTC
(In reply to comment #1)
> I'm not sure that a build timestamp is really particularly useful for a project
> that has branches, but if it's that important to you, yeah, apply it.

The build timestamp is used in the dbus-1.dll version info file and helps to distinguish dbus binary versions where patches are not in upstream as done for example by the KDE on windows project 

https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/entry/portage/win32libs-sources/dbus-src/dbus-src-1.4.10-20110302.py

patch applied to dbus-1.4 - merge to master will follow

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.