Bug 40598

Summary: Remove support for legacy Presence interface
Product: Telepathy Reporter: Will Thompson <will>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: marco.barisione
Version: git masterKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/wjt/telepathy-gabble-wjt.git/commit/?h=fd.o-40598-remove-legacy-Presence
Whiteboard: r+
i915 platform: i915 features:

Description Will Thompson 2011-09-03 03:22:36 UTC
oggis_ | hey, let's kill the legacy presence interface in gabble
oggis_ | it still advertises and implements it, right?
oggis_ | I noticed that constructing the dbus-glib structures and 
         emitting the signals costs three times as much CPU wise for the 
         same presence updates for the legacy presence IF than the 
         SimplePresence one
oggis_ | so, drop the G_IMPLEMENT_INTERFACE for Conn.I.Presence, gain a 
         4x speedup in presence signal emission (think facebook roster 
         :brr), break ... nobody?
oggis_ | fwiw tp-qt4 hasn't ever implemented any high level API on top of 
         the legacy presence IF, and I don't think anybody has used the 
         low level interface from it for that either
oggis_ | has any version of empathy or anything else we actually care 
         about used the old presence IF?
   wjt | oggis_: tp-glib client side doesn't use it either.
   wjt | oggis_: let's do it. great idea.

I also checked Empathy. It doesn't use it. Branch to follow.
Comment 1 Jonny Lamb 2011-09-03 04:48:26 UTC
Neat.
Comment 2 Will Thompson 2011-09-05 10:55:06 UTC
Merged to master for 0.13.6; ta!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.