Bug 40562

Summary:	McdTransport terminated connection attempts don't trigger status change
Product:	Telepathy	Reporter:	Vivek Dasmohapatra <vivek>
Component:	mission-control	Assignee:	Vivek Dasmohapatra <vivek>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	marco.barisione
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/vivek/telepathy-mission-control/log/?h=early-connecting-status-semi-hack
Whiteboard:	review+
i915 platform:		i915 features:

Description Vivek Dasmohapatra 2011-09-01 10:40:59 UTC

If we have an McdTransport plugin in residence, connections attempts 
can fail as a result of these before a McdConnection connetion attempt
is made: Since there is no state change, no status change signal is omitted,
which can be confusing for UIs and so forth:

• Available status is requested
• McdAccount tries to go online
  • McdTransport intervenes here: this may fail
• "Real" connection attempt is made iff the transport says "Ok"

This branch makes the McdAccount's status go to CONNECTING as soon
as possible, so that early termination due to McdTransport failure
can generate the appropriate status change signal.

Note that this doesn't affect vanilla MC as we don't (currently)
ship with any transport plugins, but there's WIP to provide 
Network Manager etc integration, which would be affected as it 
uses the McdTransport mechanism.

Comment 1 Will Thompson 2011-09-05 09:53:40 UTC

This looks reasonable, if it works. :)

(The whole stars-on-the-right-hand-side-of-comments thing bothers me, though. I
think it adds visual noise, and makes comments harder to edit later.)

Comment 2 Vivek Dasmohapatra 2011-09-07 08:36:50 UTC

Comment amended, released in 5.8.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.