| Summary: | Improve error reporting for invalid accounts | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | mission-control | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/wjt/telepathy-mission-control-wjt.git/log/?h=40337-invalid-account-error-reporting | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
Here's a branch that took much longer than I expected (as is typical). src/mcd-account-manager.c | 61 ++++++++--------- src/mcd-account-manager.h | 9 --- src/mcd-account.c | 108 ++++++++++++++++++++----------- src/mcd-account.h | 2 +- tests/twisted/account-manager/bad-cm.py | 20 +++--- 5 files changed, 110 insertions(+), 90 deletions(-) Looks good. On the two new patches:
+ { "account": 12,
+ "password": "secrecy",
+ }, signature='sv')
...
+ assertContains("account", e.message)
I think perhaps choosing the "account" parameter as the one to break and then assert is in the message is a little too easy to break on the callback to CreateAccount, but whatever.
Looks fine otherwise.
Thanks; I made it break 'password' instead, and merged le branch. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
On the mailing list, Christophe-Marie Duquesne wrote: > What do you do to add a gtalk account? I am stuck with: > > mc-tool add gabble/jabber myuser@gmail.com string:password=mypassword > > Whatever I do, I always end with the same error > mc-tool: The supplied CM parameters were not valid > (which is apparently not a message from mc-tool.c) The message comes from MC itself. As I remarked on the list, this is a particularly unhelpful message, given that MC knows perfectly well which parameter(s) were invalid. I have the beginnings of a branch to fix this.