| Summary: | Task: Add olpc-phonetic option to am symbol table | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Walter Bender <walter> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | svu |
| Version: | unspecified | Keywords: | patch |
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch to add oloc-phonetic option to am
add description for am olpc-phonetic variant to rules/base.xml.in patch for adding variant to base.extras.xml.in adding olpc-phonetic to base.extra.xml.in |
||
|
Description
Walter Bender
2011-05-16 14:31:35 UTC
Sorry, where is the patch? Created attachment 46785 [details]
patch to add oloc-phonetic option to am
Not sure why this didn't attach with the ticket the first time...
Committed. Why do you not propose the patch for base.xml.in (or base.extras.xml.in). Do you not want that variant to be visible in GUIs? Ignorance on my part. I'll look into it and get back to you ASAP. Thanks. Created attachment 46787 [details]
add description for am olpc-phonetic variant to rules/base.xml.in
As per suggestion, added a description to the rules/base.xml.in file for the new symbols option for am.
would not it be more correct to put it into base.extras.xml.in? According to the rules http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules I was following the lead of whomever added the OLPC options to for the Afghan keyboards. I'll prepare a patch for extras and perhaps a second patch to move the OLPC afghani options there as well. Created attachment 46815 [details] [review] patch for adding variant to base.extras.xml.in As per suggestion, adding variant to extras. Please ignore 46787 your patch adds phonetic-alt to extras. what about olpc-phonetic? Created attachment 46839 [details] [review] adding olpc-phonetic to base.extra.xml.in Sorry. Not enough sleep lately. Hopefully I got it correct this time. Right, replaced that... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.