| Summary: | Patch for India Malayalam enhanced inscript layout with Indian Rupee Sign | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Mahesh T Pai <paivakil> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | NEEDINFO |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch for symbols/in file
Patch for rules/base.xml patch for rules/base Patch for rules/evdev.xml Patches for rules base.xml.in |
||
|
Description
Mahesh T Pai
2011-03-06 06:03:33 UTC
Created attachment 44169 [details] [review] Patch for rules/base.xml Adding patch for rules/base.xml Not sure if patches for rules/evdev.xml and rules/base are reqoired. will add them in next post anyway. Created attachment 44170 [details] [review] patch for rules/base Patch for rules/base Created attachment 44171 [details] [review] Patch for rules/evdev.xml Patch for rules/evdev.xml Thanks for your contribution! Unfortunately you're patching wrong files - they are results of the build process. Could you please provide patches for base.xml.in, and base.*.part files? Thank you (In reply to comment #4) > Could you please provide patches for base.xml.in, and base.*.part > files? Certainly yes; looking at those files now. What about symbols/in ? Will the submitted patch do? For a moment, the patch for symbols/in looks ok. Created attachment 44175 [details] [review] Patches for rules base.xml.in The patch is against base.xml.in from http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-2.0.tar.bz2 I cannot figure out what to do about the base.*.part thing you mentioned. I tried doing a `grep -i mal ./* in rules/ directory, and only result, apart from base.xml.in is base.lists.part. Did I miss something? I am very sorry - I am only doing this for my own use - just submitting the modifications upstream; I am not a software guy, just that I have been using Debian for close to 10 years now. Well, first of all - it would be better if patches were made not against the stable release but against git. I will try to accomodate your patch for base.xml.in Regarding the base file - what exactly do you want to achieve with your original patch for rules/base? (In reply to comment #9) > Well, first of all - it would be better if patches were made not against the > stable release but against git. I will try to accomodate your patch for > base.xml.in > Err.... emmm... I was thinking that I am working only with plain text files; I remember simply modifying the files in symbols/ and things worked; of course, I had not figured out how to submit the patches upstreak. I have never used git so far; and even using svn / cvs will take me one or two hours to figure out - not that I cannot do it. Again, apologies. > Regarding the base file - what exactly do you want to achieve with your > original patch for rules/base? <feeling sheepish> Dunno; just found the existing two layouts (mal and mal_lalitha) listed in the files, and thought that the proposed layout too should be added in those files too. Ok, do not bother. Your patch is settled in git One, hopefully final, question: are you sure that people will always want to use Rupee as RAlt-4? I am asking because we already have xkb option that triggers that mapping - perhaps people could set it explicitly? In that case, if, say, tomorrow someone asks for Rupee as RAlt-5, we won't have to remove that mapping. Also, next time, please do "diff -u". In your current format the patches are incorrect:) (In reply to comment #11) > Ok, do not bother. Your patch is settled in git Thanks. > One, hopefully final, question: I will be happy to answer any number of questions from upstream deelopers; that is only way I can repay you. ;-D > are you sure that people will always want to > use Rupee as RAlt-4? I am asking because we already have xkb option that > triggers that mapping - perhaps people could set it explicitly? In that case, > if, say, tomorrow someone asks for Rupee as RAlt-5, we won't have to remove > that mapping. This (people asking for different key for the ₹ sign) is highly unlikely. AFAIK, while the layout for language may vary, position for characters like !, @, #, &, ?, etc. rarely changes. I guess same logic would apply to the Rupee symbol. The position is also proposed as common across Indian English keyboard and Inscript layouts for Indic languages. This _proposal_ can be found at http://malayalam.kerala.gov.in/images/8/80/Qwerty_enhancedinscriptkeyboardlayout.pdf (t is available after a registration process on C-DAC's web site. > Also, next time, please do "diff -u". In your current format the patches are > incorrect:) Definitely yes. Will note it. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.