Bug 34354

Summary:	[Patch] New keyboard layout for Taiwan
Product:	xkeyboard-config	Reporter:	Bryce Harrington <bryce>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	NEEDINFO
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-Add-layout-for-Taiwan-keyboards.patch 0002-Add-tw-file.patch

Description Bryce Harrington 2011-02-16 11:22:57 UTC

Another patch from Ubuntu by Arne Goetje, which adds a keyboard layout for Taiwan.

Sorry, I don't have further reference info on the patch, as no Ubuntu bug report was filed.  Arne was a Canonical employee in Taiwan who worked on xkeyboard-config a little in 2010 and added this patch (I guess to enable his own keyboard).  His domain of expertise was I18N so I trust the patch is valid and likely worth consideration for inclusion upstream as well.

Comment 1 Bryce Harrington 2011-02-16 11:24:08 UTC

Created attachment 43447 [details] [review]
0001-Add-layout-for-Taiwan-keyboards.patch

Comment 2 Sergey V. Udaltsov 2011-02-17 16:15:24 UTC

I'm afraid you forgot to include the symbols/tw file itself

Comment 3 Bryce Harrington 2011-03-04 12:40:39 UTC

Created attachment 44139 [details] [review]
0002-Add-tw-file.patch

Ah sorry about that, here it is.

Comment 4 Sergey V. Udaltsov 2011-03-04 13:16:28 UTC

Great!

Committed. Just one thing. Now, the variant descriptions are complete in base.xml.in - they should include the prefix from the layout. I updated the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.