| Summary: | tarball still contains generated files | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | minor | ||
| Priority: | medium | CC: | hp |
| Version: | 1.4.x | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/dbus-smcv.git;a=shortlog;h=refs/heads/14-dist-cleanup | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Remove references to dbus-md5, which hasn't been used for at least 8 years
Don't distribute dbus-arch-deps.h in the tarball Don't distribute dbus-daemon.1 in the tarball |
||
|
Description
Simon McVittie
2011-02-15 05:13:46 UTC
Created attachment 43373 [details] [review] Remove references to dbus-md5, which hasn't been used for at least 8 years Created attachment 43374 [details] [review] Don't distribute dbus-arch-deps.h in the tarball It's generated by configure and specific to a system, so there's no point. Created attachment 43375 [details] [review] Don't distribute dbus-daemon.1 in the tarball It's generated by configure. Also use a more normal way to distribute man pages that are actually source, and use man1_MANS rather than auto-detecting the section from the man page, which is best-practice and slightly faster. (Last patch for now; review would be appreciated.) Comment on attachment 43373 [details] [review] Remove references to dbus-md5, which hasn't been used for at least 8 years Yay for deleting code. Looks good! Comment on attachment 43374 [details] [review] Don't distribute dbus-arch-deps.h in the tarball I wonder if there's any value in listing dbus-arch-deps.h in a _HEADERS variable at all now, but it should be harmless. Looks good. (In reply to comment #4) > (From update of attachment 43373 [details] [review]) > Yay for deleting code. Looks good! Applied, 1.4.4/1.5.0 (In reply to comment #5) > (From update of attachment 43374 [details] [review]) > I wonder if there's any value in listing dbus-arch-deps.h in a _HEADERS > variable at all now Yes: files in [nodist_]dbusarchinclude_HEADERS are automatically installed in $(dbusarchincludedir) and we rely on that. Applied, 1.4.4/1.5.0 Comment on attachment 43375 [details] [review] Don't distribute dbus-daemon.1 in the tarball Looks fine, though it's weird that in automake, man pages are not default disted; I had to look that up. Maybe worth a comment in the source? (In reply to comment #7) > (From update of attachment 43375 [details] [review]) > Looks fine, though it's weird that in automake, man pages are not default > disted; I had to look that up. Maybe worth a comment in the source? Committed, with comments. The rationale is that they're often generated with docbook, help2man or (as we do for one of them) sed substitutions. I note with amusement that the CMake build system contains a doclifter'd copy of the dbus-launch, etc. man pages in docbook fomat. I wonder whether it'd be worth moving to Docbook for the man pages in general... then we'd get free HTML for the website. 1.4.4/1.5.0 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.