Bug 33761

Summary: TpAccountChannelRequest: doesn't expose the TpChannelRequest
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/chan-request-33761
Whiteboard:
i915 platform: i915 features:

Description Guillaume Desmottes 2011-01-31 07:24:18 UTC 
TpAccountChannelRequest currently doesn't expose the underlying TpChannelRequest used during the request. That means that the client can't use for example the Requests_Satisfied property from Handle_Channels.

I suggest to fix this by adding this signal on TpAccountChannelRequest:


 /**
   * TpAccountChannelRequest::got-channel-request:
   * @self: a #TpAccountChannelRequest
   * @channel_request: a #TpChannelRequest having its object-path defined but
   * not guaranteed to be prepared
   *
   * Emitted to let the caller know about the #TpChannelRequest being used
   * to request the channel.
   *
   * This can be useful for example to compare with the #TpChannelRequest
   * objects received from the requests_satisfied argument of
   * #TpSimpleHandlerHandleChannelsImpl to check if the client is asked to
   * handle the channel he just requested.
   *
   * Since: 0.13.UNRELEASED
   */
Comment 1 Guillaume Desmottes 2011-01-31 07:39:06 UTC 
After discussion on IRC with Will, we agreed that a signal wasn't very convenient to use. So we'll go for a property (+ accessor) exposing the TpChannelRequest which can be NULL. User can connect to notify: if it wants to know when the property is set.
Comment 3 Guillaume Desmottes 2011-02-09 04:18:29 UTC 
Merged; will be in 0.13.13

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.