Bug 32497

Summary:	TpBaseClient crashes when HandleChannels is called multiple times for the same channel
Product:	Telepathy	Reporter:	Sjoerd Simons <sjoerd>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/sjoerd/telepathy-glib.git;a=shortlog;h=refs/heads/base-client-refcounting
Whiteboard:	review+ (modulo minor indentation woes)
i915 platform:		i915 features:

Description Sjoerd Simons 2010-12-18 07:33:46 UTC

Another victim of the horribly wrong semantic that invalidated gets signalled both for the dbus object going away and for the object disposing (booo, bad). In an interesting twist this causes TpBaseClient to try and  remove  a TpProxy twice when it gets replaced in its own has hash table.. Which also means it gets unreffed twice.. Patch in tne url field

Comment 1 Will Thompson 2010-12-20 04:26:34 UTC

The indentation in the bugfix doesn't match the surrounding stuff (two-space rather than four-space inside the function call parens) but it looks functionally right.


<wjt> sjoerd: another fix for the bug would be to disconnect from Invalidated before removing from the hash table
<sjoerd> wjt: yeah but then i have to save the signal id somewhere etc

which seems fair enough.

Comment 2 Sjoerd Simons 2010-12-20 06:22:57 UTC

Fix merged in master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.