Bug 3247

Summary: Setting the DAC mode when depth >8 produces problems with some BIOSes
Product: xorg Reporter: Egbert Eich <eich>
Component: Driver/VesaAssignee: Egbert Eich <eich>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: high CC: david.c.sterratt, erik.andren, sndirsch, whizzter
Version: gitKeywords: patch
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Simple Fix none

Description Egbert Eich 2005-05-09 09:39:13 UTC
Setting the DAC Palette format with VBE function 0x08 causes problems on some
BIOSes when depth >8.
The attached patch avoids this setting.
Comment 1 Egbert Eich 2005-05-09 09:40:18 UTC
Created attachment 2644 [details] [review]
Simple Fix
Comment 2 Egbert Eich 2005-05-09 10:17:43 UTC
2005-05-09  Egbert Eich  <eich-at-freedesktop-dot-org>

        * programs/Xserver/hw/xfree86/drivers/vesa/vesa.c: (VESASetMode):
        Setting the DAC Palette format with VBE function 0x08 causes
        problems on some BIOSes when depth > 8.
        The attached patch avoids this setting (Bugzilla #3247).

I keep this open in case it is making problems.
Comment 3 Adam Jackson 2005-11-16 08:20:04 UTC
*** Bug 2150 has been marked as a duplicate of this bug. ***
Comment 4 David Sterratt 2005-11-16 09:48:07 UTC
According to Bug 2150 (the duplicate of this bug) the simple patch attached to
this bug report works in some circumstances but is strictly wrong according to
the VESA spec. There is a patch (also very simple) in 2150 that should bring the
driver in line with the VESA spec.
Comment 5 Erik Andren 2006-04-23 06:53:19 UTC
Someone with cvs commit access should evaluate the bug 2150 and this bugs
patches and commit the most proper one.
Comment 6 Jonas Lund 2006-04-28 10:52:49 UTC
Definetly go for the patch that was attached to 2150 as it obeys the spec (and
will work on the affected card that caused me to report earlier).
Comment 7 Erik Andren 2006-05-31 13:19:02 UTC
Link to patch: https://bugs.freedesktop.org/attachment.cgi?id=2065
Comment 8 Daniel Stone 2006-06-03 02:40:23 UTC

*** This bug has been marked as a duplicate of 2150 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.