Bug 32004

This branch includes:

* a bugfix for the notification
* a set of getters/properties for AutomaticPresence, with notification
* a getter/property for NormalizedName, with notification
* an async setter for AutomaticPresence
* somewhat better (although still patchy) test coverage

It doesn't include a property or change notification for Parameters, which I notice only has a getter.

For 0.12 I'm inclined to just change the documentation of requested-* to indicate that they don't actually have change notification, since this has been the case since before 0.10 and nobody noticed.

The unpacking would look nicer with tp_value_array_unpack... oh, that doesn't copy the values. Never mind.

+   * Since: 0.9.0
+   */
+  g_object_class_install_property (object_class, PROP_AUTOMATIC_PRESENCE_TYPE,
+      g_param_spec_uint ("automatic-presence-type",

The Since: annotation lies!

The rest of my comments are nitpicks; I don't mind if they're changed or not.

+  GSimpleAsyncResult *simple;
+
+  g_return_val_if_fail (TP_IS_ACCOUNT (account), FALSE);
+  g_return_val_if_fail (G_IS_SIMPLE_ASYNC_RESULT (result), FALSE);
+
+  simple = G_SIMPLE_ASYNC_RESULT (result);
+
+  if (g_simple_async_result_propagate_error (simple, error))
+    return FALSE;
+
+  g_return_val_if_fail (g_simple_async_result_is_valid (result,
+          G_OBJECT (account), tp_account_set_automatic_presence_async), FALSE);
+
+  return TRUE;

_tp_implement_finish_void() ?

+  g_value_init (&value, TP_STRUCT_TYPE_SIMPLE_PRESENCE);
+  g_value_take_boxed (&value, dbus_g_type_specialized_construct (
+          TP_STRUCT_TYPE_SIMPLE_PRESENCE));
+  arr = (GValueArray *) g_value_get_boxed (&value);
+
+  g_value_set_uint (arr->values, type);
+  g_value_set_static_string (arr->values + 1, status);
+  g_value_set_static_string (arr->values + 2, message);

Might be nicer as tp_value_array_build(). No big deal though.

All fixed. I didn't make the corresponding changes to TpAccount's existing async methods, since basically none of them are tested...

Fixed in git for 0.13.8