Bug 31918

Summary:	TpAccount API for Account.I.Addressing
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	jonny.lamb
Version:	0.13	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/account-addressing
Whiteboard:	review+
i915 platform:		i915 features:

Description Simon McVittie 2010-11-25 07:20:24 UTC

Some slightly higher-level API for Addressing would be nice. Here's a branch.

Comment 1 Jonny Lamb 2010-11-29 05:00:01 UTC

Just two things wrong:

 * You're not freeing the priv->uri_schemes GStrv.
 * You forgot to document tp_account_get_feature_quark_addressing.

Comment 2 Simon McVittie 2010-12-01 04:32:25 UTC

(In reply to comment #1)
>  * You're not freeing the priv->uri_schemes GStrv.

Oops, fixed.

>  * You forgot to document tp_account_get_feature_quark_addressing.

That's deliberate, those functions appear in a <SUBSECTION Private> (the documented API for them is to use the macros). I could remove the unnecessary documentation for the two existing ones if you want?

Comment 3 Jonny Lamb 2010-12-01 05:23:29 UTC

(In reply to comment #2)
> That's deliberate, those functions appear in a <SUBSECTION Private> (the
> documented API for them is to use the macros). I could remove the unnecessary
> documentation for the two existing ones if you want?

Meh, whatever. I saw the other two documented and so thought it was necessary.

gogogogogogogo

Comment 4 Simon McVittie 2010-12-01 05:27:13 UTC

Thanks, fixed in git for 0.13.8. You might also be interested in Bug #32004.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.